// 修复前
actor Cache {
var items: [String: Data] = [:]
func fetch(_ key: String) async throws -> Data {
if items[key] == nil {
items[key] = try await download(key)
}
return items[key]!
}
}
// 修复后
actor Cache {
var items: [String: Data] = [:]
func fetch(_ key: String) async throws -> Data {
if let existing = items[key] { return existing }
let data = try await download(key)
items[key] = data
return data
}
}
第 34 行：使用 withTaskGroup 代替在循环中创建任务。
// 修复前
for url in urls {
Task { try await fetch(url) }
}
// 修复后
try await withThrowingTaskGroup(of: Data.self) { group in
for url in urls {
group.addTask { try await fetch(url) }
}
for try await result in group {
process(result)
}
}
Review Swift concurrency code for correctness, modern API usage, and adherence to project conventions. Report only genuine problems - do not nitpick or invent issues.
Review process:
Scan for known-dangerous patterns using references/hotspots.md to prioritize what to inspect.
Check for recent Swift 6.2 concurrency behavior using references/new-features.md.
Validate actor usage for reentrancy and isolation correctness using references/actors.md.
Ensure structured concurrency is preferred over unstructured where appropriate using references/structured.md.
Check unstructured task usage for correctness using references/unstructured.md.
Verify cancellation is handled correctly using references/cancellation.md.
Validate async stream and continuation usage using references/async-streams.md.
Check bridging code between sync and async worlds using references/bridging.md.
Review any legacy concurrency migrations using references/interop.md.
Cross-check against common failure modes using references/bug-patterns.md.
If the project has strict-concurrency errors, map diagnostics to fixes using references/diagnostics.md.
If reviewing tests, check async test patterns using references/testing.md.
If doing a partial review, load only the relevant reference files.
Core Instructions
Target Swift 6.2 or later with strict concurrency checking.
If code spans multiple targets or packages, compare their concurrency build settings before assuming behavior should match.
Prefer structured concurrency (task groups) over unstructured (Task {}).
Prefer Swift concurrency over Grand Central Dispatch for new code. GCD is still acceptable in low-level code, framework interop, or performance-critical synchronous work where queues and locks are the right tool – don't flag these as errors.
If an API offers both async/await and closure-based variants, always prefer async/await.
Do not introduce third-party concurrency frameworks without asking first.
Do not suggest @unchecked Sendable to fix compiler errors. It silences the diagnostic without fixing the underlying race. Prefer actors, value types, or sending parameters instead. The only legitimate use is for types with internal locking that are provably thread-safe.
Output Format
Organize findings by file. For each issue:
State the file and relevant line(s).
Name the rule being violated.
Show a brief before/after code fix.
Skip files with no issues. End with a prioritized summary of the most impactful changes to make first.
Example output:
DataLoader.swift
Line 18: Actor reentrancy – state may have changed across theawait.
// Before
actor Cache {
var items: [String: Data] = [:]
func fetch(_ key: String) async throws -> Data {
if items[key] == nil {
items[key] = try await download(key)
}
return items[key]!
}
}
// After
actor Cache {
var items: [String: Data] = [:]
func fetch(_ key: String) async throws -> Data {
if let existing = items[key] { return existing }
let data = try await download(key)
items[key] = data
return data
}
}
Line 34: UsewithTaskGroup instead of creating tasks in a loop.
// Before
for url in urls {
Task { try await fetch(url) }
}
// After
try await withThrowingTaskGroup(of: Data.self) { group in
for url in urls {
group.addTask { try await fetch(url) }
}
for try await result in group {
process(result)
}
}
Summary
Correctness (high): Actor reentrancy bug on line 18 may cause duplicate downloads and a force-unwrap crash.
Structure (medium): Unstructured tasks in loop on line 34 lose cancellation propagation.
End of example.
References
references/hotspots.md - Grep targets for code review: known-dangerous patterns and what to check for each.
references/new-features.md - Swift 6.2 changes that alter review advice: default actor isolation, isolated conformances, caller-actor async behavior, @concurrent, Task.immediate, task naming, and priority escalation.
references/actors.md - Actor reentrancy, shared-state annotations, global actor inference, and isolation patterns.
references/structured.md - Task groups over loops, discarding task groups, concurrency limits.
references/unstructured.md - Task vs Task.detached, when Task {} is a code smell.
