Skill Composition

• Depends on : None
• Compatible with : None
• Conflicts with : None
• Related Skills : None

Quick Start

Assumptions

• Team uses Git for version control
• Pull requests are used for code changes
• Team has defined coding standards
• Automated tests are available

Compatibility

• Works with GitHub, GitLab, Bitbucket
• Language-agnostic review principles
• Can be adapted to any team size

Test Scenario Matrix

Technical Guardrails & Security Threat Model

1. Security & Privacy (Threat Model)

• Top Threats : Injection attacks, authentication bypass, data exposure

• Data Handling : Sanitize all user inputs to prevent Injection attacks. Never log raw PII

• Secrets Management : No hardcoded API keys. Use Env Vars/Secrets Manager

• Authorization : Validate user permissions before state changes

2. Performance & Resources

• Execution Efficiency : Consider time complexity for algorithms
• Memory Management : Use streams/pagination for large data
• Resource Cleanup : Close DB connections/file handlers in finally blocks

3. Architecture & Scalability

• Design Pattern : Follow SOLID principles, use Dependency Injection
• Modularity : Decouple logic from UI/Frameworks

4. Observability & Reliability

• Logging Standards : Structured JSON, include trace IDs request_id
• Metrics : Track error_rate, latency, queue_depth
• Error Handling : Standardized error codes, no bare except
• Observability Artifacts :
  • Log Fields : timestamp, level, message, request_id
  • Metrics : request_count, error_count, response_time
  • Dashboards/Alerts : High Error Rate > 5%

Agent Directives & Error Recovery

(ข้อกำหนดสำหรับ AI Agent ในการคิดและแก้ปัญหาเมื่อเกิดข้อผิดพลาด)

• Thinking Process : Analyze root cause before fixing. Do not brute-force.
• Fallback Strategy : Stop after 3 failed test attempts. Output root cause and ask for human intervention/clarification.
• Self-Review : Check against Guardrails & Anti-patterns before finalizing.
• Output Constraints : Output ONLY the modified code block. Do not explain unless asked.

Definition of Done

• Review process documented
• PR template with checklist
• Review checklist available
• Comment guidelines defined
• Severity levels established
• PR size guidelines set
• Turnaround SLAs defined
• Automated checks in place
• Metrics dashboard configured
• Team trained on standards

Anti-patterns / Pitfalls

• ⛔ Don't : Log PII, catch-all exception, N+1 queries
• ⚠️ Watch out for : Common symptoms and quick fixes
• 💡 Instead : Use proper error handling, pagination, and logging

Reference Links

• Google's Code Review Guide
• GitHub's Pull Request Best Practices
• Atlassian's Code Review Guide

Versioning & Changelog

• Version : 1.0.0
• Changelog :
  • 2026-02-22: Initial version with complete template structure

Weekly Installs

–

Source

smithery.ai/ski…tandards

First Seen

–