receiving-code-review by obra/superpowers
npx skills add https://github.com/obra/superpowers --skill receiving-code-review代码审查需要技术评估,而非情感表演。
核心原则: 实施前验证。假设前询问。技术正确性高于社交舒适度。
WHEN receiving code review feedback:
1. READ: 完整阅读反馈,不作反应
2. UNDERSTAND: 用自己的话复述要求(或提问)
3. VERIFY: 对照代码库实际情况检查
4. EVALUATE: 对此代码库在技术上是否合理?
5. RESPOND: 技术性确认或有理有据的反对
6. IMPLEMENT: 一次处理一项,每项都测试
绝对不要:
应改为:
IF any item is unclear:
STOP - 暂时不要实施任何内容
ASK 对不明确的事项进行澄清
WHY: 事项之间可能相关。部分理解 = 错误实施。
示例:
your human partner: "Fix 1-6"
你理解了 1,2,3,6。对 4,5 不清楚。
❌ 错误做法:现在实施 1,2,3,6,稍后再问 4,5
✅ 正确做法:"我理解了事项 1,2,3,6。在继续之前需要对 4 和 5 进行澄清。"
广告位招租
在这里展示您的产品或服务
触达数万 AI 开发者,精准高效
BEFORE implementing:
1. 检查:对此代码库在技术上是否正确?
2. 检查:是否会破坏现有功能?
3. 检查:当前实现的原因是什么?
4. 检查:是否在所有平台/版本上都能工作?
5. 检查:审查者是否理解完整上下文?
IF suggestion seems wrong:
用技术推理进行反驳
IF can't easily verify:
如实说明:"I can't verify this without [X]. Should I [investigate/ask/proceed]?"
IF conflicts with your human partner's prior decisions:
先停止并与你的 human partner 讨论
your human partner 的规则: "外部反馈 - 保持怀疑,但要仔细检查"
IF reviewer suggests "implementing properly":
grep codebase for actual usage
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
IF used: Then implement properly
your human partner 的规则: "你和审查者都向我汇报。如果我们不需要这个功能,就不要添加。"
FOR multi-item feedback:
1. 首先澄清任何不明确的事项
2. 然后按此顺序实施:
- 阻塞性问题(导致中断、安全问题)
- 简单修复(拼写错误、导入)
- 复杂修复(重构、逻辑)
3. 单独测试每个修复
4. 验证没有回归问题
在以下情况时进行反驳:
如何反驳:
如果不便公开反驳,发出信号: "Strange things are afoot at the Circle K"
当反馈正确时:
✅ "Fixed. [简要描述更改内容]"
✅ "Good catch - [具体问题]. Fixed in [位置]."
✅ [直接修复并在代码中展示]
❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ 任何感谢表达
为何不感谢: 行动胜于言辞。直接修复。代码本身表明你收到了反馈。
如果你发现自己要写"Thanks": 删除它。改为陈述修复内容。
如果你反驳了但你是错的:
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
✅ "Verified this and you're correct. My initial understanding was wrong because [原因]. Fixing."
❌ 冗长的道歉
❌ 为你为何反驳进行辩护
❌ 过度解释
事实性地陈述纠正,然后继续。
| 错误 | 修正方法 |
|---|---|
| 表演性同意 | 陈述要求或直接行动 |
| 盲目实施 | 先对照代码库验证 |
| 批量处理不测试 | 一次一项,每项都测试 |
| 假设审查者是对的 | 检查是否会破坏功能 |
| 避免反驳 | 技术正确性 > 舒适度 |
| 部分实施 | 首先澄清所有事项 |
| 无法验证但仍继续 | 说明限制,请求指示 |
表演性同意(错误):
Reviewer: "Remove legacy code"
❌ "You're absolutely right! Let me remove that..."
技术验证(正确):
Reviewer: "Remove legacy code"
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
YAGNI(正确):
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
不明确事项(正确):
your human partner: "Fix items 1-6"
你理解了 1,2,3,6。对 4,5 不清楚。
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
在 GitHub 上回复内联审查评论时,请在评论线程中回复(gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies),而不是作为顶层的 PR 评论。
外部反馈 = 需要评估的建议,而非必须遵循的命令。
验证。质疑。然后实施。
杜绝表演性同意。始终保持技术严谨性。
每周安装量
24.1K
仓库
GitHub 星标数
107.7K
首次出现
Jan 19, 2026
安全审计
安装于
opencode20.7K
gemini-cli19.4K
codex19.4K
github-copilot18.4K
cursor17.8K
amp17.1K
Code review requires technical evaluation, not emotional performance.
Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.
WHEN receiving code review feedback:
1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each
NEVER:
INSTEAD:
IF any item is unclear:
STOP - do not implement anything yet
ASK for clarification on unclear items
WHY: Items may be related. Partial understanding = wrong implementation.
Example:
your human partner: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
BEFORE implementing:
1. Check: Technically correct for THIS codebase?
2. Check: Breaks existing functionality?
3. Check: Reason for current implementation?
4. Check: Works on all platforms/versions?
5. Check: Does reviewer understand full context?
IF suggestion seems wrong:
Push back with technical reasoning
IF can't easily verify:
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
IF conflicts with your human partner's prior decisions:
Stop and discuss with your human partner first
your human partner's rule: "External feedback - be skeptical, but check carefully"
IF reviewer suggests "implementing properly":
grep codebase for actual usage
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
IF used: Then implement properly
your human partner's rule: "You and reviewer both report to me. If we don't need this feature, don't add it."
FOR multi-item feedback:
1. Clarify anything unclear FIRST
2. Then implement in this order:
- Blocking issues (breaks, security)
- Simple fixes (typos, imports)
- Complex fixes (refactoring, logic)
3. Test each fix individually
4. Verify no regressions
Push back when:
How to push back:
Signal if uncomfortable pushing back out loud: "Strange things are afoot at the Circle K"
When feedback IS correct:
✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]
❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ ANY gratitude expression
Why no thanks: Actions speak. Just fix it. The code itself shows you heard the feedback.
If you catch yourself about to write "Thanks": DELETE IT. State the fix instead.
If you pushed back and were wrong:
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
❌ Long apology
❌ Defending why you pushed back
❌ Over-explaining
State the correction factually and move on.
| Mistake | Fix |
|---|---|
| Performative agreement | State requirement or just act |
| Blind implementation | Verify against codebase first |
| Batch without testing | One at a time, test each |
| Assuming reviewer is right | Check if breaks things |
| Avoiding pushback | Technical correctness > comfort |
| Partial implementation | Clarify all items first |
| Can't verify, proceed anyway | State limitation, ask for direction |
Performative Agreement (Bad):
Reviewer: "Remove legacy code"
❌ "You're absolutely right! Let me remove that..."
Technical Verification (Good):
Reviewer: "Remove legacy code"
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
YAGNI (Good):
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
Unclear Item (Good):
your human partner: "Fix items 1-6"
You understand 1,2,3,6. Unclear on 4,5.
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
When replying to inline review comments on GitHub, reply in the comment thread (gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies), not as a top-level PR comment.
External feedback = suggestions to evaluate, not orders to follow.
Verify. Question. Then implement.
No performative agreement. Technical rigor always.
Weekly Installs
24.1K
Repository
GitHub Stars
107.7K
First Seen
Jan 19, 2026
Security Audits
Gen Agent Trust HubPassSocketPassSnykPass
Installed on
opencode20.7K
gemini-cli19.4K
codex19.4K
github-copilot18.4K
cursor17.8K
amp17.1K
97,600 周安装